Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] Move logic from Map::cycleDebugOptions to GLFW example app #16005

Merged
merged 1 commit into from
Dec 4, 2019
Merged

[core] Move logic from Map::cycleDebugOptions to GLFW example app #16005

merged 1 commit into from
Dec 4, 2019

Conversation

brunoabinader
Copy link
Member

This function was mostly used by the Android API, which is no longer necessary (we can still implement it using the map debug accessor and modifier).

@brunoabinader brunoabinader added the Core The cross-platform C++ core, aka mbgl label Dec 4, 2019
@tmpsantos
Copy link
Contributor

Oh, we use this a lot for development. :-O

@brunoabinader brunoabinader changed the title [core] Remove Map::cycleDebugOptions [core] Move logic from Map::cycleDebugOptions to GLFW example app Dec 4, 2019
@brunoabinader
Copy link
Member Author

@tmpsantos @pozdnyakov refactored the patch to move the logic of cycling debug options to the GLFW example app directly.

@brunoabinader brunoabinader merged commit 1e2cd1e into master Dec 4, 2019
@brunoabinader brunoabinader deleted the map-cycledebugoptions branch December 4, 2019 09:50
@tobrun tobrun mentioned this pull request Dec 16, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pozdnyakov pozdnyakov pozdnyakov approved these changes

@tmpsantos tmpsantos tmpsantos approved these changes

@tobrun tobrun Awaiting requested review from tobrun

Assignees
No one assigned
Labels
Core The cross-platform C++ core, aka mbgl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunoabinader @tmpsantos @pozdnyakov