This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Remove pausing of file sources in background #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macdrevx
commented
Oct 29, 2021
This behavior was introduced in response to a crash in 2016, but has led to watchdog terminations when apps enter the background. Subsequent refactoring to the file source implementations makes this behavior unnecessary. Equivalent behavior was also removed from Maps SDK v10 (mapbox-maps-ios).
macdrevx
force-pushed
the
bug/watchdog-crash
branch
from
dcbed13 to
ede7659
Compare
knov
approved these changes
Oct 29, 2021
alexshalamov
approved these changes
Oct 29, 2021
|
I was hoping it could fix #637 but it didn't |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior was introduced in response to a crash in 2016, but has led to watchdog terminations when apps enter the background. Subsequent refactoring to the file source implementations makes this behavior unnecessary. Equivalent behavior was also removed from Maps SDK v10 (mapbox-maps-ios).