Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Avoid crash in NSOrthography category method #619

Merged
merged 4 commits into from
Aug 20, 2021
Merged

Avoid crash in NSOrthography category method #619

merged 4 commits into from
Aug 20, 2021

Conversation

macdrevx
Copy link
Contributor

Fixes #562

@macdrevx macdrevx requested a review from a team August 20, 2021 18:00
@macdrevx macdrevx mentioned this pull request Aug 20, 2021
Closed
@macdrevx macdrevx force-pushed the ah/voice-over-crash branch 2 times, most recently from 49fa08d to 27e9f57 Compare August 20, 2021 20:26
@macdrevx macdrevx force-pushed the ah/voice-over-crash branch from 27e9f57 to f1177c1 Compare August 20, 2021 20:27
1ec5
1ec5 approved these changes Aug 20, 2021
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we’d add nullability macros to NSOrthography+MGLAdditions.h, but the changes here look good regardless.

platform/ios/src/NSOrthography+MGLAdditions.m Outdated Show resolved Hide resolved
@macdrevx macdrevx merged commit de911fd into main Aug 20, 2021
@macdrevx macdrevx deleted the ah/voice-over-crash branch August 20, 2021 20:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1ec5 1ec5 1ec5 approved these changes

@nishant-karajgikar nishant-karajgikar nishant-karajgikar approved these changes

Assignees
No one assigned
Labels
bug 🪲 skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[iOS] Enabling Voice Over crashes map in app when English language is not installed on device
3 participants
@macdrevx @1ec5 @nishant-karajgikar