This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 122
iOS 14 location privacy settings update #361
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabian-guerra
changed the title
Fabian lm ios14 337
iOS 14 location privacy settings update
Aug 4, 2020
fabian-guerra
force-pushed
the
fabian-lm-ios14-337
branch
from
August 5, 2020 16:28
a602e92
to
48a67ea
Compare
fabian-guerra
requested review from
a team,
julianrex and
nishant-karajgikar
and removed request for
1ec5
August 5, 2020 16:41
|
||
- (void)requestTemporaryFullAccuracyAuthorizationWithPurposeKey:(NSString *)purposeKey { | ||
if (@available(iOS 14.0, *)) { | ||
[self.locationManager requestTemporaryFullAccuracyAuthorizationWithPurposeKey:purposeKey]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing we need to add a new purpose key in the plist now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DO we need to make any changes to documentation to reflect this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The key comes from Apple. But yes we will have to modify our docs.
nishant-karajgikar
approved these changes
Aug 7, 2020
I think this requires a changelog entry. |
fabian-guerra
force-pushed
the
fabian-lm-ios14-337
branch
from
August 11, 2020 16:29
48a67ea
to
34dc835
Compare
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #337
iOS 14 has a new privacy setting related to location accuracy. It means that users may be able to revoke the level of location accuracy the app has permission to use. When this happens apps will not be able to change manually this setting. However in order to request full location accuracy for a short period of time this pr introduces
requestTemporaryFullAccuracyAuthorizationWithPurposeKey
which is on pair ofCLLocationManager. requestTemporaryFullAccuracyAuthorizationWithPurposeKey
. Developers can check the location accuracyMGLLocationManager. accuracyAuthorization
and if it isCLAccuracyAuthorizationReducedAccuracy
then they can callrequestTemporaryFullAccuracyAuthorizationWithPurposeKey
to gain full accuracy for a short period of time. Enough to complete their use case.