Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

fix crash on nil completion #311

Merged
merged 2 commits into from
Jul 22, 2020
Merged

fix crash on nil completion #311

merged 2 commits into from
Jul 22, 2020

Conversation

gloubibou
Copy link
Contributor

Fences off call to completion() to fix crash on nil completion

@gloubibou gloubibou requested a review from 1ec5 as a code owner May 26, 2020 13:57
@gloubibou gloubibou requested a review from a team May 26, 2020 13:57
1ec5
1ec5 reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting and fixing this issue! Suggested changelog entry:

  • Fixed a crash when calling -[MGLMapView setVisibleCoordinateBounds:edgePadding:animated:completionHandler:] with a nil completion handler. (#311)

platform/macos/src/MGLMapView.mm Outdated Show resolved Hide resolved
@1ec5 1ec5 added bug Something isn't working macOS labels Jun 4, 2020
@gloubibou @1ec5
Update platform/macos/src/MGLMapView.mm
400e632 
Co-authored-by: Minh Nguyễn <mxn@1ec5.org>
@knov knov requested review from jmkiley and fabian-guerra July 6, 2020 15:50
fabian-guerra
fabian-guerra approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@fabian-guerra fabian-guerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this crash. Just add a changelog entry as described in this comment

@knov knov added this to the release-y milestone Jul 13, 2020
@knov knov requested review from captainbarbosa and removed request for jmkiley July 21, 2020 19:13
@captainbarbosa
Copy link
Contributor

Just kicked off CI - I'll follow up with the changelog entry separately.

@captainbarbosa captainbarbosa merged commit a5afc60 into mapbox:master Jul 22, 2020
@captainbarbosa
Copy link
Contributor

Tests passed. Thanks for your contribution @gloubibou!

captainbarbosa added a commit that referenced this pull request Jul 22, 2020
@captainbarbosa
[macos] Update changelog with entry from #311
cff89c9
@captainbarbosa captainbarbosa mentioned this pull request Jul 22, 2020
Merged
captainbarbosa added a commit that referenced this pull request Nov 17, 2020
@captainbarbosa @jmkiley
[macos] Update changelog with entry from #311 (#345)
05ae0fb 
Co-authored-by: Jordan Kiley <jmkiley@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1ec5 1ec5 1ec5 left review comments

@fabian-guerra fabian-guerra fabian-guerra approved these changes

@captainbarbosa captainbarbosa Awaiting requested review from captainbarbosa

Assignees

@captainbarbosa captainbarbosa

Labels
bug Something isn't working macOS
Projects
None yet
Milestone
release-yerba-maté
Development

Successfully merging this pull request may close these issues.
5 participants
@gloubibou @captainbarbosa @1ec5 @fabian-guerra @knov