This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Add offline pack context setter #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ec5
commented
Apr 30, 2020
| [pack setContext:newContext completionHandler:^(NSError * _Nullable error) { | ||
| XCTAssertNil(error); | ||
| XCTAssertNotNil(weakPack); | ||
| XCTAssertEqualObjects(weakPack.context, newContext, @"Offline pack context should match the updated context specified by the application."); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
8e5dd29ff47e6f75607f2353c9d0703322c94381 tries to work around mapbox/mapbox-gl-native#16450 by reloading the offline packs, storing the Edit: That was a typo, fixed in f88052c8de03cc9425496b5317e232e1749b3ede. |
fabian-guerra
approved these changes
Apr 30, 2020
Set the offline pack’s associated metadata, then replace the offline pack’s underlying offline region based on a fresh reload, without touching the master array of offline packs.
1ec5
force-pushed
the
1ec5-offline-context-setter-256
branch
from
4393c82
to
ed4495f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
-[MGLOfflinePack setContext:completionHandler:]method for replacing the data associated with an offline pack, such as a name.To do:
Fixes #256.
/cc @mapbox/maps-ios