Skip rerenders for mousemove handlers when in selection modes #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Dec 18, 2019
|
This is great, would love to see it get merged so I don't need to run a custom build of draw. 👍 |
|
Would also love to see this merged if possible :) I think it'd be a great improvement. |
kkaefer
force-pushed
the
skip-render-for-select-handler-mousemove-events
branch
from
e97eda5 to
20178b3
Compare
|
Any idea when there will be a release with this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces CPU usage and fixes #760
CPU usage is still high when moving the mouse, but the remaining CPU usage is in queryRendereredFeatures which is used to determine the shape of the mouse pointer.