[GLJS-781] Improved performance of markers dragging #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
underoot
force-pushed
the
underoot-GLJS-781
branch
2 times, most recently
from
f888e9a
to
fd2efd4
Compare
underoot
commented
Mar 28, 2024
underoot
force-pushed
the
underoot-GLJS-781
branch
from
fd2efd4
to
e2ebd26
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created snapshot of state and make comparision to understand that we need to update only markers at the moment. Helped improve performance of markers dragging in Safari
Before:
https://github.com/mapbox/mapbox-gl-directions/assets/2480721/d28d9156-4e5e-4ad3-9329-d1574b1fa180
After:
https://github.com/mapbox/mapbox-gl-directions/assets/2480721/ea18fd57-6833-420f-b4dc-12524a4ecb09