Conversation
| @@ -1,2 +1,2 @@ | |||
| github "raphaelmor/Polyline" ~> 4.2 | |||
| github "mapbox/turf-swift" ~> 0.3 | |||
| github "mapbox/turf-swift" ~> 0.3.0 | |||
There was a problem hiding this comment.
We need to specify the patch version for any pre-v1.0 dependency. Otherwise, both Carthage and CocoaPods will automatically pull down a newer minor version, in this case v0.5.0, causing lots of compiler errors.
We weren’t seeing the issue locally in this repository because of the Cartfile.resolved file. However, Carthage doesn’t look at that file when installing dependencies for downstream projects.
|
Do we need to update entry in |
I think the |
|
This build keeps failing because Carthage is pulling in Turf v0.5.0. I thought Carthage doesn’t treat two v0.x versions as being compatible? It doesn’t fail locally for me because it always pulls in v0.3.0. I think the CircleCI cache is interfering here again. |
All tests pass locally on my side. When running Carthage update getting: |
| name: Restore cache | ||
| keys: | ||
| - carthage-v1-{{ .Environment.CIRCLE_JOB }}-{{ checksum "Cartfile.resolved" }} | ||
| - carthage-v1-{{ .Environment.CIRCLE_JOB }} # used if checksum fails |
|
Pushed to CocoaPods trunk in CocoaPods/Specs@93e52fb: |
This PR cherry-picks #440, which fixes a geometry issue when using the Map Matching API, and updates the Xcode project, CocoaPods podspec, and readme for v0.31.1.
/cc @mapbox/navigation-ios @hactar