Proguard adjustments #1174
Proguard adjustments #1174
Conversation
MapboxAndroidDemo/proguard-rules.pro
Outdated
| @@ -121,13 +121,17 @@ | |||
| -keep class android.arch.lifecycle.** { *; } | |||
| -keep class com.mapbox.android.core.location.** { *; } | |||
| -keep class com.mapbox.mapboxsdk.** { *; } | |||
There was a problem hiding this comment.
This shouldn't be necessary because we're using the @Keep annotation in the Maps SDK.
There was a problem hiding this comment.
https://circleci.com/gh/mapbox/mapbox-android-demo/2413 is where this pr is stemming from
MapboxAndroidDemo/proguard-rules.pro
Outdated
| @@ -121,13 +121,17 @@ | |||
| -keep class android.arch.lifecycle.** { *; } | |||
| -keep class com.mapbox.android.core.location.** { *; } | |||
| -keep class com.mapbox.mapboxsdk.** { *; } | |||
| -keep class com.mapbox.android.gestures.** { *; } | |||
There was a problem hiding this comment.
This shouldn't be necessary, there's no reflection/native code.
There was a problem hiding this comment.
There was a problem hiding this comment.
From what I understand, all of those notes state that the class names are obfuscated and code would be inaccessible from another project. This, however, shouldn't cause any issue for the demo app and since the demo app is not consumed by any other project. The -dontnote entry for all of those notes should be enough.
MapboxAndroidDemo/proguard-rules.pro
Outdated
| @@ -121,13 +121,17 @@ | |||
| -keep class android.arch.lifecycle.** { *; } | |||
| -keep class com.mapbox.android.core.location.** { *; } | |||
| -keep class com.mapbox.mapboxsdk.** { *; } | |||
| -keep class com.mapbox.android.gestures.** { *; } | |||
| -keep class com.mapbox.mapboxsdk.plugins.** { *; } | |||
There was a problem hiding this comment.
This shouldn't be necessary, there's no reflection/native code.
MapboxAndroidDemo/proguard-rules.pro
Outdated
| @@ -121,13 +121,17 @@ | |||
| -keep class android.arch.lifecycle.** { *; } | |||
| -keep class com.mapbox.android.core.location.** { *; } | |||
| -keep class com.mapbox.mapboxsdk.** { *; } | |||
| -keep class com.mapbox.android.gestures.** { *; } | |||
| -keep class com.mapbox.mapboxsdk.plugins.** { *; } | |||
| -dontnote com.mapbox.** | |||
langsmith
force-pushed
the
ls-proguard-adjustments
branch
2 times, most recently
from
2ed476b to
10594bb
Compare
langsmith
force-pushed
the
ls-proguard-adjustments
branch
from
10594bb to
64b67b7
Compare
langsmith
force-pushed
the
ls-proguard-adjustments
branch
from
919681e to
a8bb7b6
Compare
|
Changes here look ok, @LukasPaczos ? |
MapboxAndroidDemo/proguard-rules.pro
Outdated
| -keep class android.arch.lifecycle.** { *; } | ||
| -keep class com.mapbox.android.core.location.** { *; } | ||
| -keep class com.mapbox.mapboxsdk.** { *; } | ||
| -dontnote class com.mapbox.android.telemetry.** |
There was a problem hiding this comment.
What was the reason to keep this and below classes before? Is it not needed anymore? What are the notes produced in this case?
There was a problem hiding this comment.
What are the notes produced in this case?
See the screenshots above.
What was the reason to keep this and below classes before? Is it not needed anymore?
Was keeping them to cut down on Proguard messages, but the ones in the screenshots above were new. Based on #1174 (comment), sounded like switching things to dontnote was the remedy.
If you had to address the lines seen in say, https://user-images.githubusercontent.com/4394910/63796375-cd93d280-c8ba-11e9-9617-11c7b9c45fe4.png, what would you do?
There was a problem hiding this comment.
I agree with dontnote for gestures, plugins and maps. However, there's nothing about telemetry, location or lifecycle in those screenshots.
There was a problem hiding this comment.
ah, I see. Well I suspect they were there from past Proguard issues. You good with keeping -keep next to them and only doing dontnote for gestures, plugins, and maps?
There was a problem hiding this comment.
Sure, we can keep them unchanged and tackle in a separate PR if they are actually obsolete.
There was a problem hiding this comment.
Ok, adjusted them and re-based. Take a look when you get a chance 🙇
langsmith
force-pushed
the
ls-proguard-adjustments
branch
from
11cff97 to
09b7f6b
Compare
I'm still trying get CircleCI to release the demo app to the Play Store. The current blocker seems to be the amount/type of Proguard messages, which then make the release process run out of memory. This pr adjusts the rules to cut down on the number of Proguard messages that are coming in.