Skip to content

Conversation

@mourner
Copy link
Member

@mourner mourner commented Jan 22, 2015

Changes the API to return indexed vertices. Closes #4.

We need to evaluate the approach in the real world first before making a change like this because it comes with a performance cost of ~15-20%.

This also breaks the 3D vertices use cases, we need to think about it API-wise.

@mourner
Copy link
Member Author

mourner commented Jan 29, 2015

I should probably also make this optional.

@kkaefer
Copy link
Member

kkaefer commented Feb 18, 2015

what's the status of this?

@mourner
Copy link
Member Author

mourner commented Feb 18, 2015

@kkaefer never tried it in practice but it works on the earcut end and I can quickly rebase the branch to work on master. Do you think it should be the default behavior?

@kkaefer
Copy link
Member

kkaefer commented Feb 18, 2015

@mourner we're exclusively doing indexed draw calls in native, so we'd need some way of doing this anyway.

@mourner
Copy link
Member Author

mourner commented Feb 18, 2015

@kkaefer OK, I'll look if this can be merged to master in a way that doesn't degrade performance (e.g. making it optional).

@mourner
Copy link
Member Author

mourner commented Feb 19, 2015

Another pull request for the same: #11

@mourner mourner closed this Feb 19, 2015
@mourner mourner deleted the indexed branch April 30, 2015 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Indexed vertices API

2 participants