This repository has been archived by the owner on Oct 30, 2021. It is now read-only.
Fix two errors identified by clang-tidy #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoid leaking memory when error is throw - incorrect usage of std::move which prevents copy elison Detected using the setup from mapbox/node-cpp-skel#63
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang-tidyis a static analyzer capable of detecting a wide range of bugs and memory leaks.@mapbox/core-tech is spearheading getting
clang-tidyworking for node c++ modules at mapbox/node-cpp-skel#63.In time we will provide docs for how to enable on
clang-tidyon travis forcarmen-cache.Currently I ran
clang-tidylocally to assess the codebase here and found two problems worth fixing quickly.The following PR fixes a potential memory leak and incorrect usage of
std::move. The incorrectstd::moveusage is minor. The memory leak could trigger if a newRocksDBCacheis created in JS using an invalid or empty string, or if the database cannot be opened./cc @GretaCB