WIP: vscript support #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blixibon
reviewed
May 16, 2020
| // HACK: (03/25/09) Then the player goes across a transition it doesn't spawn and register | ||
| // it's instance. We're hacking around this for now, but this will go away when we get around to | ||
| // having entities cross transitions and keep their script state. | ||
| if ( !g_pGameRules->IsMultiplayer() && g_pScriptVM && (gpGlobals->eLoadType == MapLoad_Transition) ) |
There was a problem hiding this comment.
Will proper save/restore support for VScripts fix this issue?
There was a problem hiding this comment.
This is a hack from Alien Swarm, not something that save/restore will impact.
| @@ -21,6 +21,9 @@ $Conditional MAPBASE "1" | |||
|
|
|||
| // Toggles Mapbase's RPC implementation | |||
| $Conditional MAPBASE_RPC "1" | |||
|
|
|||
| // Toggles VScript implementation (note: interfaces still exist, just the provided implementation is not present) | |||
| $Conditional MAPBASE_VSCRIPT "1" | |||
There was a problem hiding this comment.
Thank you for adding a unique VPC conditional and C++ preprocessor for this. I will probably use it for any Mapbase-specific expansions or changes to the VScript implementation unless you intended it to be used for more specific purposes only. (e.g. how it's used in vscript_shared.cpp)
reductor
commented
May 19, 2020
|
Just so you know, in Valve's implementation regexes aren't save-loadable, and the |
* Fixes scopes not being restored from a save * Fixes closure environment not being restored from a save * Fixes singletons not being properly restored from a save * Fixes root table being incorrectly duplicated in a save * Fixes various cases where duplicate objects could be created from a save
WhiteRedDragons
pushed a commit
to WhiteRedDragons/Mapbase-Fork
that referenced
this pull request
Nov 25, 2022
Manhack changes required for npc_lost_soul
samisalreadytaken
pushed a commit
to samisalreadytaken/source-sdk-2013
that referenced
this pull request
Jan 15, 2023
Merge Houndeye PR from ez1/dev into ez1/mapbase
VDeltaGabriel
pushed a commit
to Project-P2009/p2009_sdk
that referenced
this pull request
Apr 27, 2023
WIP: vscript support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting this PR to start the discussion/review while some remaining parts are left over
Remaining parts