Fix OOB access#332
Merged
Merged
Conversation
Blixibon
approved these changes
Jan 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the loop fails its
i < 48condition, it will access out of array bounds onGetWeaponright after. This was mostly benign becauseCHandle m_hMyWeapons[48]is followed byCHandle m_hActiveWeaponin memory, som_hMyWeapons[48]would accessm_hActiveWeapon, which would always be null because the entity can't have an active weapon with no weapons.PR Checklist
developbranch OR targets another branch with a specific goal in mind