Skip to content

Request to Merge #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: parent7402e
Choose a base branch
from
Open

Request to Merge #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions lib/utilcode/src/main/java/com/blankj/utilcode/util/ScreenUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,74 @@ public static float getScreenDensity() {
public static int getScreenDensityDpi() {
return Resources.getSystem().getDisplayMetrics().densityDpi;
}




/**
* Return X (width) of the screen expressed as dots-per-inch.
*
* @return the width of screen density expressed as dots-per-inch
*/
public static int getScreenXDpi() {
return Resources.getSystem().getDisplayMetrics().xdpi;
}

/**
* Return Y (height) of the screen expressed as dots-per-inch.
*
* @return the height of screen density expressed as dots-per-inch
*/
public static int getScreenYDpi() {
return Resources.getSystem().getDisplayMetrics().ydpi;
}



/**
* Return the distance between the given View's X (start point of View's width) and the screen width.
*
* @return the distance between the given View's X (start point of View's width) and the screen width.
*/
public float calculateDistanceByX(View view) {
int[] point = new int[0];
view.getLocationOnScreen(point);
return (getScreenWidth() - point[0]).toFloat();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category Functionality severity potentially major

Use cast to float instead of .toFloat() for int conversion.

Tell me more ​

In the calculateDistanceByX and calculateDistanceByY methods, you're using .toFloat() to convert the result to a float. However, this method doesn't exist for int in Java. Instead, you should use a cast to float. Change return (getScreenWidth() - point[0]).toFloat(); to return (float)(getScreenWidth() - point[0]);. Make the same change in calculateDistanceByY.

Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.

}
Comment on lines +144 to +148
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

category Functionality severity potentially major

Initialize the 'point' array with a size of 2.

Tell me more ​

In the calculateDistanceByX and calculateDistanceByY methods, you're initializing the point array with a size of 0. This will cause an ArrayIndexOutOfBoundsException when you try to access point[0] or point[1]. Instead, initialize the array with a size of 2 like this: int[] point = new int[2];. This will allow the getLocationOnScreen method to properly populate the array with the x and y coordinates.

Chat with Korbit by mentioning @korbit-ai, and give a 👍 or 👎 to help Korbit improve your reviews.


/**
* Return the distance between the given View's Y (start point of View's height) and the screen height.
*
* @return the distance between the given View's Y (start point of View's height) and the screen height.
*/
public float calculateDistanceByY(View view) {
int[] point = new int[0];
view.getLocationOnScreen(point);
return (getScreenHeight() - point[1]).toFloat();
}

/**
* Return the X coordinate of the given View on the screen.
*
* @return X coordinate of the given View on the screen.
*/
public int getViewX(View view){
int[] point = new int[0];
view.getLocationOnScreen(point);
return point[0];
}

/**
* Return the Y coordinate of the given View on the screen.
*
* @return Y coordinate of the given View on the screen.
*/
public int getViewY(View view){
int[] point = new int[0];
view.getLocationOnScreen(point);
return point[1];
}


/**
* Set full screen.
Expand Down