Skip to content

Fix travis build #325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 24, 2019
Merged

Fix travis build #325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b1fc50
Delete unused variables
wwwdata Mar 24, 2019
69650c1
Fix echo dependency and add go 1.11 build
wwwdata Mar 24, 2019
e456e79
Remove go 1.8
wwwdata Mar 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
language: go

go:
- "1.8"
- "1.9"
- "1.10"
- "1.11"

sudo: false

Expand All @@ -16,7 +16,7 @@ install:
# optional dependencies
- go get -u github.com/gin-gonic/gin
- go get -u github.com/gorilla/mux
- go get -u github.com/labstack/echo/...
- go get -u github.com/labstack/echo

script:
- ginkgo -r -cover --randomizeAllSpecs --randomizeSuites --failOnPending --trace --race --progress
Expand Down
7 changes: 3 additions & 4 deletions api_interfaces_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,16 +412,15 @@ var _ = Describe("Test partial CRUD implementation : Updater", func() {

var _ = Describe("Test partial CRUD implementation : Deleter", func() {
var (
api *API
rec *httptest.ResponseRecorder
payload, payloadID SomeData
api *API
rec *httptest.ResponseRecorder
payload SomeData
)

BeforeEach(func() {
api = NewAPI("v1")
api.AddResource(SomeData{}, ResourceDeletionOnly{})
rec = httptest.NewRecorder()
payloadID = SomeData{ID: "12345", Data: "A Brezzn"}
payload = SomeData{Data: "A Brezzn"}
})

Expand Down
9 changes: 1 addition & 8 deletions api_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,8 +1051,7 @@ var _ = Describe("RestHandler", func() {

Context("marshal errors correctly", func() {
var (
source *fixtureSource
post1Json map[string]interface{}
source *fixtureSource

api *API
rec *httptest.ResponseRecorder
Expand All @@ -1063,12 +1062,6 @@ var _ = Describe("RestHandler", func() {
"1": {ID: "1", Title: "Hello, World!"},
}, false}

post1Json = map[string]interface{}{
"id": "1",
"title": "Hello, World!",
"value": nil,
}

api = NewAPI("")
api.AddResource(Post{}, source)

Expand Down