Skip to content

Fix inconsequential but annoying analyse job errors #4024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Fix inconsequential but annoying analyse job errors #4024

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fac449
ignore special files when queueing up model analysis jobs
Floppy Apr 17, 2025
773b389
don't bother parsing metadata for datapackage files
Floppy Apr 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/jobs/scan/check_model_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ def perform(model_id, scan: true)
model.check_for_problems_later
end
# Run analysis job on individual files
model.model_files.each do |file|
model.model_files.without_special.each do |file|
file.analyse_later
end
end
Expand Down
2 changes: 1 addition & 1 deletion app/jobs/scan/model/add_new_files_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def perform(model_id, include_all_subfolders: false)
file_list(model.path, model.library, include_all_subfolders: include_all_subfolders).each do |filename|
# Create the file
file = model.model_files.find_or_create_by(filename: filename.gsub(model.path + "/", ""))
file.parse_metadata_later if file.valid?
file.parse_metadata_later if file.valid? && file.filename != "datapackage.json"
end
model.parse_metadata_later
end
Expand Down
Loading