Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for minikube v1.34.0 #123

Merged
merged 1 commit into from
Oct 1, 2024
+13 −7
Merged

feat: support for minikube v1.34.0 #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
feat: support for minikube v1.34.0
  • Loading branch information
@manusa
manusa committed Oct 1, 2024
commit 876e06a739babb48139093a24c6335c9d40fe2cd
12 changes: 6 additions & 6 deletions .github/workflows/runner.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Test Action
uses: ./
with:
minikube version: v1.33.0
minikube version: v1.34.0
kubernetes version: ${{ matrix.kubernetes }}
github token: ${{ secrets.GITHUB_TOKEN }}
- name: Validate Minikube
Expand All @@ -41,7 +41,7 @@ jobs:
- name: Test Action
uses: ./
with:
minikube version: v1.33.0
minikube version: v1.34.0
kubernetes version: v1.30.0
github token: ${{ secrets.GITHUB_TOKEN }}
driver: docker
Expand All @@ -64,7 +64,7 @@ jobs:
- name: Test Action
uses: ./
with:
minikube version: v1.33.0
minikube version: v1.34.0
kubernetes version: v1.29.0
github token: ${{ secrets.GITHUB_TOKEN }}
start args: '--addons=registry --addons=metrics-server'
Expand All @@ -85,7 +85,7 @@ jobs:
- name: Test Action
uses: ./
with:
minikube version: v1.33.0
minikube version: v1.34.0
kubernetes version: v1.30.0
github token: ${{ secrets.GITHUB_TOKEN }}
start args: '--addons=ingress'
Expand All @@ -110,7 +110,7 @@ jobs:
- name: Test Action
uses: ./
with:
minikube version: v1.33.0
minikube version: v1.34.0
kubernetes version: ${{ matrix.kubernetes }}
github token: ${{ secrets.GITHUB_TOKEN }}
container runtime: ${{ matrix.container_runtime }}
Expand All @@ -135,7 +135,7 @@ jobs:
- name: Test Action
uses: ./
with:
minikube version: v1.33.0
minikube version: v1.34.0
kubernetes version: ${{ matrix.kubernetes }}
github token: ${{ secrets.GITHUB_TOKEN }}
- name: Validate Minikube
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
- name: Setup Minikube
uses: manusa/actions-setup-minikube@v2.11.0
with:
minikube version: 'v1.33.0'
minikube version: 'v1.34.0'
kubernetes version: 'v1.30.0'
github token: ${{ secrets.GITHUB_TOKEN }}
- name: Interact with the cluster
Expand Down
1 change: 1 addition & 0 deletions src/__tests__/install.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ describe('install module test suite', () => {
jest.resetModules();
jest.mock('@actions/core');
jest.mock('@actions/io', () => ({
mkdirP: jest.fn(() => {}),
mv: jest.fn(() => {})
}));
jest.mock('path');
Expand Down
5 changes: 5 additions & 0 deletions src/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ const install = async (minikube, inputs) => {
core.info('Installing Minikube');
logExecSync(`chmod +x ${minikube}`);
const minikubeDirectory = path.dirname(minikube);
// See https://github.com/kubernetes/minikube/pull/18648
// https://github.com/kubernetes/minikube/issues/15835
// Since v1.34.0 minikube doesn't automatically append .minikube to the MINIKUBE_HOME variable unless the directory exists
// By creating it manually we ensure compatibility with current and legacy versions.
await io.mkdirP(path.join(minikubeDirectory, '.minikube'));
await io.mv(minikube, path.join(minikubeDirectory, 'minikube'));
core.exportVariable('MINIKUBE_HOME', minikubeDirectory);
core.addPath(minikubeDirectory);
Expand Down