Skip to content

Refactored autoCommit for consumeFirstMessage methods. #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2016
Merged

Refactored autoCommit for consumeFirstMessage methods. #62

merged 2 commits into from
Dec 16, 2016

Conversation

manub
Copy link
Owner

@manub manub commented Dec 16, 2016

@alexadriaanse I think this leaks less into the Config. Let me know what you think.

@alexadriaanse
Copy link
Contributor

Makes sense. I assume you'll be reverting the change I made to EmbeddedKafkaConfig, and change the props.put line to props.put("enable.auto.commit", s"${autoCommit}")? I didn't see those changes in your commit.

@manub
Copy link
Owner Author

manub commented Dec 16, 2016

Yes - I forgot about that but thanks for noting!

@alexadriaanse
Copy link
Contributor

Perfect. New commit looks great to me, I can't think of any issues with these changes.

@manub manub merged commit cd2fc4a into master Dec 16, 2016
@manub manub deleted the refactored_auto_commit branch December 16, 2016 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manub @alexadriaanse