Added a way to create topics and brokers by passing a custom configuration #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -239,4 +242,12 @@ sealed trait EmbeddedKafkaSupport { | |||
| broker.startup() | |||
| broker | |||
| } | |||
|
|
|||
| def createCustomTopic(topic: String, topicConfig: Properties)(implicit config: EmbeddedKafkaConfig): Unit = { | |||
| val zkSessionTimeoutMs = 10000 | |||
There was a problem hiding this comment.
maybe this and following vals should be pulled out of this method, at the trait level, in order to avoid instantation every time the method gets called
There was a problem hiding this comment.
Good point. I've moved them at the trait level as suggested.
|
LGTM, just a minor comment. |
…n when whe create custom topics
|
Thanks - I'll be doing a release by the end of the week, 0.5.1. |
|
@lucapertile actually it slipped out of my mind that we don't have scaladoc nor readme for this. Could you please create another PR before releasing? |
This was referenced May 17, 2016
| @@ -239,4 +246,8 @@ sealed trait EmbeddedKafkaSupport { | |||
| broker.startup() | |||
| broker | |||
| } | |||
|
|
|||
| def createCustomTopic(topic: String, topicConfig: Properties)(implicit config: EmbeddedKafkaConfig): Unit = { | |||
There was a problem hiding this comment.
Working with Properties in Scala is a bit ugly, have you considered using a Map[String, String] for the interface of this function instead ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the formatting noise and implemented the suggested changes. This PR adds support for custom topic and broker creation by enabling clients to pass a custom config when they create a broker or a topic.