Update to MantisBT 2.6.0 (Resolving the inline script problem)#6
Update to MantisBT 2.6.0 (Resolving the inline script problem)#6alleen merged 6 commits intomantisbt-plugins:masterfrom mrkpatchaa:master
Conversation
|
@kkremitzki perhaps we can test this on FC ? |
|
don't work with 2.8.0 . on login_page.php i dont have "Sign in with google" |
|
Hi @dam326 I didn't test it with 2.8 version since it was not yet published when I pushed this update. Can you debug and tell which error you have ? |
|
@rmkpatchaa take a look at #3 (comment) |
|
@luzpaz ok. Unfortunately I don't have time for now to do it. I'll check later if I can. It should be good if someone here has a little time to dig into it. |
|
@luzpaz I think there is a misunderstanding... Dependencies for plugins given as examples are MantisBT 2.3+. |
|
Hi! I've applied the patch and it works like a charm with Mantis 2.8. Can anybody merge this PR ? @dam326 have you configured the plugin with the correct credentials? Thanks @rmkpatchaa !! Good work!! |
|
I haven't tested yet. I need to ask @kkremitzki if he can install this plugin, though I know he's busy these days. |
Why should I be ? |
.gitignore
Outdated
| *.iml | ||
| out | ||
| gen### Example user template template | ||
| ### Example user template |
There was a problem hiding this comment.
@rmkpatchaa Looks like something went wrong with your .gitignore changes, the same files are excluded twice and the comments are duplicated as well.
|
@dregad Well I thought it would be a nice feature to be able to tout for Mantis, especially that most of the popular bugtrackers provide this feature not just for GitHub but other bugtrackers as well. |
|
So you mean integrating the plugin as a standard authentication method in the core ? If yes, this is what @vboctor's comment #3 (comment) is about. |
|
@xezpeleta : i test it again and it works with mantis 2.8 ! i don't understand why it didn't work my first time. |
|
What's blocking this from merge ? |
|
In my case (MantisBT 2.10) the htaccess located at /plugins folder prevent access to the plugin.js file located at /plugins/GoogleOauth/pages/assets/js/plugin.js |
README: supports mantisbt >= v2.6 based on #6
I've update the plugin to resolve the inline script problem.
The core modification is that all javascript code is in a separate js file. The configuration is injected via meta tags.
I've also :