Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use-in-viewport when ref changes #6926

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Fix use-in-viewport when ref changes #6926

merged 2 commits into from
Oct 3, 2024

Conversation

fellmann
Copy link
Contributor

@fellmann fellmann commented Oct 1, 2024

Fixes #6812

@rtivital
Copy link
Member

rtivital commented Oct 2, 2024

Please fix errors in tests.

@rtivital
Copy link
Member

rtivital commented Oct 3, 2024

Have you validated that the solution works as expected?

@fellmann
Copy link
Contributor Author

fellmann commented Oct 3, 2024

It is working in my application, and as I understand it works for #6812 (comment) too.

@rtivital rtivital merged commit a3aec20 into mantinedev:master Oct 3, 2024
1 check passed
@rtivital
Copy link
Member

rtivital commented Oct 3, 2024

Great, thanks!

@sam-morin sam-morin mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Changing element breaks use-in-viewport hook
2 participants
@fellmann @rtivital