Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/core] fix: isNumberLike should only check for valid css #6855

Merged
merged 1 commit into from
Sep 25, 2024
Merged

[@mantine/core] fix: isNumberLike should only check for valid css #6855

merged 1 commit into from
Sep 25, 2024

Conversation

Kenzo-Wada
Copy link
Contributor

@Kenzo-Wada Kenzo-Wada commented Sep 19, 2024 •
edited
Loading

fixes: #6853

updated isNumberLike func so that it'll return true when it's valid css props. otherwise false.
eg) 2xl

I've checked all test passes, and added test for custom sizes

@rtivital rtivital merged commit 8fb3297 into mantinedev:master Sep 25, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

@sam-morin sam-morin mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom spacing not working in Stack gap prop
2 participants
@Kenzo-Wada @rtivital