Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@mantine/date] remove placeholder from TimeInput props #6793

Merged
merged 2 commits into from
Sep 25, 2024
Merged

[@mantine/date] remove placeholder from TimeInput props #6793

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
256bdfd
[@mantine/date] remove placeholder from TimeInput props
Kenzo-Wada Sep 9, 2024
7b882ec
[@mantine/date] add placeholder to Timeinput Props
Kenzo-Wada Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/@docs/demos/src/demos/dates/TimeInput/TimeInput.demo.configurator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,13 @@ function Demo() {
return (
<TimeInput
{{props}}
placeholder="Input placeholder"
/>
);
}
`;

function Wrapper(props: any) {
return <TimeInput {...props} placeholder="Input placeholder" />;
return <TimeInput {...props} />;
}

export const configurator: MantineDemo = {
Expand Down
2 changes: 1 addition & 1 deletion packages/@mantine/dates/src/components/TimeInput/TimeInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export interface TimeInputProps
extends BoxProps,
__BaseInputProps,
StylesApiProps<TimeInputFactory>,
ElementProps<'input', 'size'> {
ElementProps<'input', 'size' | 'placeholder'> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not remove this as it might be a potential breaking change. Removal from the demo is enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it!

7b882ec

/** Determines whether seconds input should be rendered */
withSeconds?: boolean;

Expand Down
Loading