Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Fix: not applied bd style prop #6282

Merged
merged 1 commit into from
May 24, 2024

Conversation

ryuhangyeong
Copy link
Contributor

@ryuhangyeong ryuhangyeong commented May 24, 2024

Description

After installing 7.10.0, it does not work properly when using bd Style props.

Example

export function Usage() {
  return (
    <div style={{ padding: 40 }}>
      <Text bd={`1px solid ${'#333'}`}>Just text</Text>
    </div>
  );
}

Before

image

After

image

@crosskayla
Copy link

Thank you 💯 Updated for this feature and would love to see it working

@rtivital rtivital merged commit 5f0ae82 into mantinedev:master May 24, 2024
1 check passed
@rtivital
Copy link
Member

Thanks!

@ryuhangyeong
Copy link
Contributor Author

@rtivital

According to my use case, I think I also need a style prop like below. 🤔

  • bdt (border-top)
  • bdr (border-right)
  • bdl (border-left)
  • bdb (border-bottom)

May I suggest an MR that adds that attribute?

@rtivital
Copy link
Member

No, let's not do that. Use style attribute or className for that.

@ryuhangyeong
Copy link
Contributor Author

Thank you for answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants