Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow null in Sparkline data array since it supports connectNulls #6352

Closed
1 of 2 tasks
fengye87 opened this issue Jun 7, 2024 · 1 comment
Closed
1 of 2 tasks

Allow null in Sparkline data array since it supports connectNulls #6352

fengye87 opened this issue Jun 7, 2024 · 1 comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)

Comments

@fengye87
Copy link

fengye87 commented Jun 7, 2024

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.10.1

What package has an issue?

@mantine/charts

What framework do you use?

Vite

In which browsers you can reproduce the issue?

All

Describe the bug

Since Sparkline supports connectNulls, we should change data prop type of number[] so to allow null element to be passed in.

If possible, include a link to a codesandbox with a minimal reproduction

No response

Possible fix

No response

Self-service

  • I would be willing to implement a fix for this issue
@rtivital rtivital added the Fixed patch Completed issues that will be published with next patch (1.0.X) label Jul 12, 2024
@rtivital
Copy link
Member

Fixed in 7.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed patch Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants