Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code to generate a ComicInfo.xml into the zip for cbz creation. #26

Merged
merged 1 commit into from
Aug 13, 2022

Conversation

garbled1
Copy link
Contributor

This adds ComicInfo.xml support to the cbz file creation. Tested with Komga.

Creates a ComicInfo.xml file in each zip, with details from mangadex so when you visit the series in Komga, you can see all the details of the manga.

Copy link
Owner

@mansuf mansuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍, looks good to me. Waiting CI to show success result

@mansuf mansuf merged commit 939dc2c into mansuf:main Aug 13, 2022
@mansuf
Copy link
Owner

mansuf commented Aug 13, 2022

Merged, thank you for your contribution 💖.

@garbled1
Copy link
Contributor Author

Just FYI, I made it so you can set chapter to None when calling the xml generation, in case you wanted to use it for the other cbz formats. I don't use them, so I wasn't entirely sure what would be appropriate..

@mansuf
Copy link
Owner

mansuf commented Aug 13, 2022

I think it doesn't make sense to implement this for cbz-volume and cbz-single to an reader like Komga. Because it should be individual chapter. Have a look at tachiyomi formats for an example.

@mansuf
Copy link
Owner

mansuf commented Aug 13, 2022

Released to v1.6.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants