v2.0.0 #25
Merged
v2.0.0 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More clean looking and elegant :)
Instead of having functions for license, description, author, and repository. Create a function that can read all of them
because of format string f"" is conflict with regex {1,}
No more "Circulare Imports" problem
kinda useless tho
Still in development, not ready to use
Regex is not scanning additional words behind patch
For removing duplicate codes ffs
- Rename NetworkObject to NetworkManager - Fix weird references and add missing references
Kinda useless tho
becaus of refactor thing
- Removed API references in main module - Refactored command (library, list, followed-list, etc) in CLI module - Removed unused class and imports
I'm putting wrong file in previous commit lmao, sorry
It's make me confusing
This only happens if server didn't support `Range` header
This only happens if server didn't support `Range` header
- Fixed "--group <id>" and "--no-group-name" throwing error (if combined), the error throwed must be if "--group all" and "--no-group-name" together - Removed unused functions
set_config_from_cli_opts() is not working
|
Refactor is complete, this PR is merged. All new features and fixes will be added to main branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR
Lately, the codes has reached unreadable state where all references is weird and abstract. This PR is created for refactoring all codes to be more open-source friendly and readable to developers who wants to understand how mangadex-downloader is working.
Any contributions to this PR will be appreciated💖
Plans
All plans is available through this project
Docs
https://mangadex-dl.mansuf.link/en/v2.0.0