Skip to content

Remove use of ember-get-config to get the current config #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
francois2metz wants to merge 1 commit into from
Closed

Remove use of ember-get-config to get the current config #360

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions addon/services/notifications.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,12 @@ import Service from '@ember/service';
import { A } from '@ember/array';
import EmberObject, { set } from '@ember/object';
import { later, cancel } from '@ember/runloop';
import config from 'ember-get-config';
import { getOwner } from '@ember/application';

const globals = config['ember-cli-notifications'] || {}; // Import app config object
function getGlobalConfig(instance) {
const config = getOwner(instance).resolveRegistration('config:environment');
return config['ember-cli-notifications'] || {}; // Import app config object
}

export default class NotificationsService extends Service {
content = A();
Expand All @@ -16,6 +19,7 @@ export default class NotificationsService extends Service {
if (!options.message) {
throw new Error('No notification message set');
}
const globals = getGlobalConfig(this);

const notification = EmberObject.create({
message: options.message,
Expand Down Expand Up @@ -123,10 +127,12 @@ export default class NotificationsService extends Service {
}

setDefaultAutoClear(autoClear) {
const globals = getGlobalConfig(this);
set(globals, 'autoClear', autoClear);
}

setDefaultClearDuration(clearDuration) {
const globals = getGlobalConfig(this);
set(globals, 'clearDuration', clearDuration);
}
}
Loading