Skip to content

Comments

Breaking: Drop support for Node 10 and Modernize syntax#320

Merged
mansona merged 8 commits intomansona:masterfrom
pichfl:modernize
Nov 9, 2021
Merged

Breaking: Drop support for Node 10 and Modernize syntax#320
mansona merged 8 commits intomansona:masterfrom
pichfl:modernize

Conversation

@pichfl
Copy link
Contributor

@pichfl pichfl commented Sep 17, 2021

  • Use native classes (available since 3.6, 3.8 being the earliest version this addon is tested against)
  • Use tagLess components (partially done before)
  • Only install ember-on-modifier if necessary

@pichfl pichfl mentioned this pull request Sep 17, 2021
@pichfl pichfl force-pushed the modernize branch 2 times, most recently from 32c1f7c to d0fc96c Compare September 17, 2021 15:03
@pichfl
Copy link
Contributor Author

pichfl commented Sep 17, 2021

@mansona I wish I would understand what's happening here.

Copy link
Owner

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor thing 👍

@pichfl pichfl force-pushed the modernize branch 2 times, most recently from 58f56bd to d34f93d Compare November 5, 2021 16:34
@mansona mansona changed the title Modernize syntax Breaking: Drop support for Node 10 and Modernize syntax Nov 5, 2021
@mansona mansona merged commit 681e05a into mansona:master Nov 9, 2021
@pichfl pichfl deleted the modernize branch November 9, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants