Skip to content

support new JsInterop syntax (JS_RC) #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jan 21, 2016
Merged

support new JsInterop syntax (JS_RC) #54

merged 12 commits into from
Jan 21, 2016

Conversation

manolo
Copy link
Owner

@manolo manolo commented Nov 15, 2015

@manolo manolo force-pushed the JS_RC branch 3 times, most recently from 3667169 to 5aa2061 Compare January 13, 2016 19:41
@manolo manolo force-pushed the JS_RC branch 2 times, most recently from 3e6eb91 to fab531a Compare January 14, 2016 00:34
@manolo manolo assigned tomivirkki and unassigned manolo Jan 18, 2016
@manolo manolo mentioned this pull request Jan 20, 2016
@manolo
Copy link
Owner Author

manolo commented Jan 20, 2016

Since legacy jsInteropMode=JS has been removed, this PR should support only new syntax.

@tehapo
Copy link
Contributor

tehapo commented Jan 20, 2016

Review status: 0 of 26 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


lib/com/vaadin/polymer/Polymer.java, line 194 [r3] (raw file):
After this change both branches of the if block seem to do about the same thing. Is the urlImported set (and the if condition) even needed anymore or could this method be simplified a bit?


package.json, line 3 [r3] (raw file):
Why is the patch version incremented by two? Why not 1.2.2? Or should this be even 1.3.0?


README.md, line 68 [r3] (raw file):
Typo. Should be support instead of suppor.


Comments from the review on Reviewable.io

@tomivirkki
Copy link
Contributor

Contains some more stuff than what the title says (bugfixes, Promise&Template API's, changes to existing API's...). But the code looks ok and compiler seems to produce stuff that works so lgtm (as soon as Teemu's findings are fixed).


Review status: 0 of 26 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.


Comments from the review on Reviewable.io

@tehapo
Copy link
Contributor

tehapo commented Jan 20, 2016

Reviewed 1 of 21 files at r1, 6 of 10 files at r2, 19 of 19 files at r3.
Review status: all files reviewed at latest revision, 3 unresolved discussions.


Comments from the review on Reviewable.io

@tehapo
Copy link
Contributor

tehapo commented Jan 21, 2016

Review status: 25 of 26 files reviewed at latest revision, 3 unresolved discussions.


package.json, line 3 [r3] (raw file):
This was discussed during our daily meeting. The version reflects Polymer version, so this is ok.


Comments from the review on Reviewable.io

@manolo
Copy link
Owner Author

manolo commented Jan 21, 2016

Yes, the PR has became big because it includes all the work in this long period. Also the title does not reflect the change since we are abandoning legacy syntax instead to support both.


Review status: 25 of 26 files reviewed at latest revision, 3 unresolved discussions.


lib/com/vaadin/polymer/Polymer.java, line 194 [r3] (raw file):
Actually we have to run importHref so as Polymer takes care of running the ok or err function depending on whether the resource is available.

I have refactored this method so as we also consider when the element has been registered previously (the user could do in the index.html page, or using vulcanized stuff, etc.)

FYI, this fixes issue #55


package.json, line 3 [r3] (raw file):
exactly we match the latest Polymer, that was decided in a meeting with Joonas and Artur some time ago.


README.md, line 68 [r3] (raw file):
Done.


Comments from the review on Reviewable.io

Adding utility function to avoid casting when binding functions to templates.
Typo.
@tehapo
Copy link
Contributor

tehapo commented Jan 21, 2016

LGTM.


Reviewed 1 of 1 files at r4, 2 of 2 files at r5.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from the review on Reviewable.io

tehapo added a commit that referenced this pull request Jan 21, 2016
support both JS & JS_RC modes
@tehapo tehapo merged commit a195903 into master Jan 21, 2016
@tehapo tehapo deleted the JS_RC branch January 21, 2016 16:14
@tehapo tehapo removed the backlog label Jan 21, 2016
@manolo manolo changed the title support both JS & JS_RC modes support new JsInterop syntax (JS_RC) Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants