-
Notifications
You must be signed in to change notification settings - Fork 24
support new JsInterop syntax (JS_RC) #54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
60633d8
to
7c25bf6
Compare
a9ccf21
to
0a28405
Compare
Add Promise interface
3667169
to
5aa2061
Compare
3e6eb91
to
fab531a
Compare
Since legacy jsInteropMode=JS has been removed, this PR should support only new syntax. |
Review status: 0 of 26 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed. lib/com/vaadin/polymer/Polymer.java, line 194 [r3] (raw file): package.json, line 3 [r3] (raw file): README.md, line 68 [r3] (raw file): Comments from the review on Reviewable.io |
Contains some more stuff than what the title says (bugfixes, Promise&Template API's, changes to existing API's...). But the code looks ok and compiler seems to produce stuff that works so lgtm (as soon as Teemu's findings are fixed). Review status: 0 of 26 files reviewed at latest revision, 3 unresolved discussions, some commit checks failed. Comments from the review on Reviewable.io |
Reviewed 1 of 21 files at r1, 6 of 10 files at r2, 19 of 19 files at r3. Comments from the review on Reviewable.io |
Review status: 25 of 26 files reviewed at latest revision, 3 unresolved discussions. package.json, line 3 [r3] (raw file): Comments from the review on Reviewable.io |
Yes, the PR has became big because it includes all the work in this long period. Also the title does not reflect the change since we are abandoning legacy syntax instead to support both. Review status: 25 of 26 files reviewed at latest revision, 3 unresolved discussions. lib/com/vaadin/polymer/Polymer.java, line 194 [r3] (raw file): I have refactored this method so as we also consider when the element has been registered previously (the user could do in the index.html page, or using vulcanized stuff, etc.) FYI, this fixes issue #55 package.json, line 3 [r3] (raw file): README.md, line 68 [r3] (raw file): Comments from the review on Reviewable.io |
Adding utility function to avoid casting when binding functions to templates. Typo.
LGTM. Reviewed 1 of 1 files at r4, 2 of 2 files at r5. Comments from the review on Reviewable.io |
Connected to manolo/gwt-polymer-elements#66