Skip to content

Commit

Permalink
multiqueue: do not reduce single queue below current level
Browse files Browse the repository at this point in the history
When the single queue size was just bumped by 1 to allow more buffers to
be added, the buffers limit could be reduced to the current level when
setting the max-size-buffers property. This would result in a stall
since the queue would not grow anymore at this point.

Prevent this by not reducing a single queue size below the current
number of buffers + 1.

https://bugzilla.gnome.org/show_bug.cgi?id=712597
  • Loading branch information
rawoul authored and sdroege committed Jan 27, 2014
1 parent 78d13b6 commit a93615a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions plugins/elements/gstmultiqueue.c
Original file line number Diff line number Diff line change
Expand Up @@ -510,8 +510,8 @@ gst_multi_queue_set_property (GObject * object, guint prop_id,
/* do not reduce max size below current level if the single queue has grown because of empty queue */
if (new_size == 0) {
q->max_size.visible = new_size;
} else {
q->max_size.visible = MAX (new_size, size.visible);
} else if (new_size > size.visible) {
q->max_size.visible = new_size;
}
tmp = g_list_next (tmp);
};
Expand Down

0 comments on commit a93615a

Please sign in to comment.