mocks: warn about small theta and large mu in float32 precision #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodeep
reviewed
Jul 14, 2023
|
This looks great! Do you want to add the update to the Changelog? |
|
Ohh also your name isn't on the author list for the files - do you want to fix that up (or in a separate PR)? You should probably be the first author on all the python wrappers :) ! |
|
I updated the warning and the changelog. No need for my name to be in the authors list for each file; I don't really see that in wide use in Python projects, and being mentioned in the readme/papers is plenty of credit! |
@lgarrison Re-worded the changelog - see if that works for you.
Fixed typo
Fixed typo
Fixed typo
Fixed typo
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #297 (comment).
Not sure if we should include the mu warning; a user is unlikely to be splitting hairs about the exact mu value above 0.98 like they would small theta. @manodeep what do you think?