-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥 remove all upload methods #63
Conversation
They aren't used anywhere (gone through lots of repos) to my knowledge. Logic like this should be handled outside of this actions.
91540fa
to
1298181
Compare
Don't get it. |
This reverts commit 4a9d54e.
Didn't find that in the 100000 clones of this action you set up. Which one is it? |
Those I use to build the stable ISOs which can be found here: https://github.com/manjaro/citestbed/blob/master/.github/workflows/iso_build.yaml They are used for the stable ISO files. |
|
anyway: is still think this shouldn't be part of this action, as it couples building the images with releasing them. IMO a proper process would be:
|
IMO we need better docs about what repos there are all and then in general reducing the number of them. It can't be, that it's so difficult to work with them. Can we find some time after stable snap to discuss that more @philmmanjaro? Also then we can hopefully remerge the PR here, at least the parts of it which remove stuff taht are really not needed anymore. |
CDNs don't list the images so a review is done on those images. Sourceforge is only optional and not promoted when we do a release. |
by the way, the only docs in that "testbed" repo:
|
There are some outdated upload methods we don't use anymore, but s3 and sf is still used. |
)" This reverts commit d08140e.
@oberon-manjaro Can you check again which lines for CDN77 upload is not needed anymore? I think we can drop OSDN upload as we don't use that for ages. SF is still our backup for download archives, even they always send emails that we use too much storage on their end ... |
They aren't used anywhere as far as I know (did go through lots of repos).
Complexity like this should be implemented on the users side.
closes #22 as a side-effect