Skip to content

[WIP] WIP address feedback on cloud audio setup recovery - #27

Merged
manikv12 merged 1 commit into
mVashith/cloud-audio-recovery-and-notificationsfrom
copilot/sub-pr-26
Mar 3, 2026
Merged

manikv12 merged 1 commit into
mVashith/cloud-audio-recovery-and-notificationsfrom
copilot/sub-pr-26

Conversation

Copilot AI commented Mar 3, 2026 •

Copy link
Copy Markdown
Contributor
  • Analyze existing SettingsApplySnapshot struct and usages
  • Replace cloudTranscriptionAPIKey: String with cloudTranscriptionAPIKeyHash: String in SettingsApplySnapshot
  • Update currentSettingsApplySnapshot() to compute SHA256 hash of API key
  • Update comparison in applySettingsChanges() to use the hash field
  • Add import CryptoKit to App.swift
  • Run tests to validate (pre-existing environment failures unrelated to changes)
  • Code review and security check

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@manikv12
manikv12 marked this pull request as ready for review March 3, 2026 19:38
Copilot AI review requested due to automatic review settings March 3, 2026 19:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@manikv12
manikv12 merged commit 93862c8 into mVashith/cloud-audio-recovery-and-notifications Mar 3, 2026
1 check failed
Copilot stopped work on behalf of manikv12 due to an error March 3, 2026 19:40
manikv12 added a commit that referenced this pull request Mar 3, 2026
)

* fix: recover cloud audio setup failures and show user notifications

* Update Sources/KeyScribe/Services/CloudTranscriber.swift

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan (#27)

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>

* Replace hasPrefix HUD alert dispatch with structured status events (#28)

* Initial plan

* Replace hasPrefix HUD notification string-matching with structured SpeechTranscriberHUDAlert events

Co-authored-by: manikv12 <49544491+manikv12@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: manikv12 <49544491+manikv12@users.noreply.github.com>

* Update Sources/KeyScribe/Services/CloudTranscriptionModelCatalogService.swift

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: address copilot and codex review threads

---------

Co-authored-by: Manik Vashith <manik.vashith@nlsnow.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants