-
Notifications
You must be signed in to change notification settings - Fork 53
Issue 347: Add TerraformOutputOnlyPlugin #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Forgot to mark this as a draft. Haven't committed tests yet. |
Codecov Report
@@ Coverage Diff @@
## master #348 +/- ##
==========================================
+ Coverage 80.04% 80.17% +0.12%
==========================================
Files 44 46 +2
Lines 1208 1256 +48
Branches 283 292 +9
==========================================
+ Hits 967 1007 +40
- Misses 95 101 +6
- Partials 146 148 +2
Continue to review full report at Codecov.
|
|
OK, this is not WIP anymore. |
| stage.decorate(PLAN, stashPlan(stage.getEnvironment())) | ||
| stage.decorate(APPLY, unstashPlan(stage.getEnvironment())) | ||
| stage.decorate(PLAN_COMMAND, stashPlan(stage.getEnvironment())) | ||
| stage.decorate(APPLY_COMMAND, unstashPlan(stage.getEnvironment())) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you clarify why the stash/unstash needed to be narrowed in this way? How is it related to outputting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anything regarding a plan file is dependent only on the execution of the plan and apply commands. In my case, I wanted to skip the PLAN_COMMAND itself while still executing the PLAN stage (I need the INIT). With the above plugin bound to the entire PLAN phase, it's still going to execute even in the absence of the plan command executing and try to stash a non-existent plan file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Thanks for the clarification.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking to Issue #152, since it touches on the concern about decorating being overly specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall.
|
Updates look good, thanks! |
…than the full PLAN and APPLY stages
3392f65 to
8922c68
Compare
Fixes issue #347: Create
TerraformOutputOnlyPluginto provide the option of producing the current Terraform state outputs, skippingterraform planandterraform apply