Skip to content

Conversation

@codezninja
Copy link
Contributor

fixes #293

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #295 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #295   +/-   ##
=======================================
  Coverage   76.04%   76.04%           
=======================================
  Files          38       38           
  Lines         981      981           
  Branches      233      233           
=======================================
  Hits          746      746           
  Misses        122      122           
  Partials      113      113           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 356fbd8...28f62cb. Read the comment docs.

@kmanning
Copy link
Collaborator

kmanning commented Sep 1, 2020

Can you update the CHANGELOG to include your change?

@kmanning
Copy link
Collaborator

kmanning commented Sep 1, 2020

Otherwise, looks great, thanks!

@kmanning kmanning added this to the v5.11 milestone Sep 1, 2020
@kmanning kmanning merged commit 83486b5 into manheim:master Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add documentation for withGlobalEnv

3 participants