Defect: GithubPRPlanPlugin - failing plan marked as success?

[kmanning]

• Investigate this

[CliffJumper]

Not sure if this is the same, but with v5.14, I'm seeing terraform plan errors "swallowed". The net effect is that I don't see the plan output in the Jenkins log.

[kmanning]

How to reproduce:

1. Create a terraform resource that will fail on terraform plan. For example, read from a file that does not exist.
2. Enable the GithubPRPlanPlugin in your pipeline - this will pipeline the output to plan.out, and stderr to plan.err
3. Run your pipeline
4. Expected: The pipeline should fail at the end of the plan command, and the error message captured in plan.err should be displayed to the user.
5. Actual: The failed terraform plan exit code is swallowed (and reported successful because of the successful tee call), and the pipeline continues. The stderr output goes unused in the plan.err file.