Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configuration scripts for new deployments #612

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Configuration scripts for new deployments #612

wants to merge 3 commits into from

Conversation

jkrivine
Copy link
Contributor

@jkrivine jkrivine commented Oct 5, 2023 •
edited
Loading

This PR does the following:

  • adds ERC20 addresses for arbitrum context
  • adds a generic script that infers and logs density and gasbase for a specific market.
    The script required some minor refactoring of existing scripts (only in use for testnet)

@jkrivine jkrivine requested a review from espendk October 5, 2023 08:20
espendk
espendk requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@espendk espendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

There's a minor issue in the new EvalMarketScript that I think should be addressed.

script/deployers/EvalMarketParameters.s.sol Outdated Show resolved Hide resolved
script/deployers/EvalMarketParameters.s.sol Outdated Show resolved Hide resolved
@jkrivine jkrivine requested a review from espendk October 13, 2023 08:18
@jkrivine jkrivine enabled auto-merge (squash) October 13, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espendk espendk Awaiting requested review from espendk

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkrivine @espendk