Skip to content

Fix permissions and minor changes #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2025
Merged

Fix permissions and minor changes #19

merged 4 commits into from
Jul 8, 2025

Conversation

manghidev
Copy link
Owner

This pull request introduces significant updates to improve Linux compatibility by dynamically handling user permissions in the Docker environment, along with several other enhancements related to usability and configuration. The most important changes include refactoring the Docker setup to support dynamic UID/GID, modifying the default behavior of Makefile commands, and introducing a new script for detecting user permissions.

Linux Compatibility Enhancements:

  • Dockerfile: Refactored user creation to dynamically handle UID/GID for Linux systems, ensuring compatibility with existing users and groups. Added logic to adjust permissions for home directories and symlinks.
  • docker-compose.yml: Added USER_UID and USER_GID arguments to support dynamic user permissions in the Docker container.
  • scripts/detect-permissions.sh: Introduced a new script to detect and export user permissions (UID/GID) based on the operating system.

Makefile Improvements:

  • Makefile: Changed the default target from help to default, which displays all available commands. Removed the logs target and added logic to detect user permissions for Linux compatibility. [1] [2] [3]

Documentation Updates:

  • README.md: Updated references to the default make command and adjusted examples to reflect the removal of the help target. [1] [2]
  • docs/COMMANDS.md: Replaced references to make help with make and removed the logs command from the list of available commands. [1] [2] [3]

Version Bump:

  • VERSION: Incremented the project version from 1.3.2 to 1.3.3.

Script Adjustments:

  • scripts/build.sh: Integrated the new detect-permissions.sh script to dynamically configure user permissions during the build process. Updated Docker commands to pass USER_UID and USER_GID as environment variables. [1] [2] [3] [4]
  • scripts/configure.sh and scripts/destroy.sh: Replaced echo with printf for consistent formatting and improved script robustness. [1] [2] [3] [4]

@manghidev manghidev self-assigned this Jul 8, 2025
@manghidev manghidev merged commit e9131bd into main Jul 8, 2025
@manghidev manghidev deleted the fix_permissions branch July 8, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant