Added tests. #3
Open
Added tests. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Bump @manekinekko. |
manekinekko
requested changes
Feb 22, 2017
| }, | ||
| "dependencies": { | ||
| "@manekinekko/google-actions-server": "^2.0.4" | ||
| "@manekinekko/google-actions-server": "dblock/google-actions-server#tests" |
Owner
There was a problem hiding this comment.
could you use @manekinekko/google-actions-server#2.0.6 instead?
Contributor
Author
|
Unfortunately this is now hitting actions-on-google/actions-on-google-nodejs#16. And they don't seem to want tests :( |
Owner
|
what do you suggest? |
Contributor
Author
|
For now just wait till actions-on-google/actions-on-google-nodejs#17 is merged and 1.0.8 is released. |
Contributor
Author
|
Maybe @manekinekko you can ping someone at Google about this, like @smishra2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A starter should have tests so that people don't forget to write them and ship fewer broken apps :)
Note that
package.jsonuses"@manekinekko/google-actions-server": "dblock/google-actions-server#tests"as this needs sfeir-open-source/google-actions-server#2 which returns theexpressinstance fromlisten()to which we can send HTTP POSTs.