Skip to content

Conversation

@dormeight
Copy link

add next(reader) to skip the headline and remove sample_1 or sample_2 from file names to locate the outputs of clonality.py

add next(reader) to skip the headline and remove sample_1 or sample_2 from file names to locate the outputs of clonality.py

file_TCRB_1=args.dir_1+"/TCRB.VJ.FREQ."+sample_1+".csv"
file_TCRB_1=args.dir_1+"/TCRB.VJ.FREQ."+".csv"
file_TCRB_2=args.dir_2+"/TCRB.VJ.FREQ."+sample_2+".csv"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you didn't take out the sample_2 in this line?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh,my god. I forgot to remove these ones. all sample_1 or sample_2 should be removed

Copy link

@aaronkarlsberg aaronkarlsberg Oct 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! @mandricigor could you modify the script to amend these two lines as well and create a new pull request?
@smangul1 I don't have authorization to merge a pull request with the master branch. Can you approve it and/or add me as a contributor?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged these changes with the Mangul USC lab fork.
@mandricigor, I recommend merging this patch into your fork.
@dormeight made a good fix.

Copy link

@aaronkarlsberg aaronkarlsberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Works with my data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants