This repository was archived by the owner on Jan 1, 2026. It is now read-only.
idb2pat: incorporate fixes from @HongThatCong#98
Open
williballenthin wants to merge 1 commit into
Open
Conversation
williballenthin
commented
Sep 21, 2020
| if ea > func.start_ea: # skip first byte | ||
| name = idc.get_name(ea) | ||
| if name != "" and idaapi.is_uname(name): | ||
| logger.debug(str("ea 0x%X has a name %s" % (ea, name))) |
Contributor
Author
There was a problem hiding this comment.
first parameter to a log method is a format string, so we can do this instead:
logger.debug("ea 0x%X has a name %s", ea, name)
williballenthin
commented
Sep 21, 2020
| f.write("---") | ||
| if os.path.exists(filename): | ||
| with open(filename, "rb") as f: | ||
| old_sigs = f.readlines() |
Contributor
Author
There was a problem hiding this comment.
probably need to decode the bytes into a string, like:
old_sigs = f.read().decode("utf-8").split("\n")
williballenthin
commented
Sep 21, 2020
| for sig in sigs: | ||
| f.write(sig) | ||
| f.write("\r\n") | ||
| f.write("---") |
Contributor
Author
There was a problem hiding this comment.
should be writing bytes, not str, since the file is open in binary mode.
williballenthin
commented
Sep 21, 2020
| sigs.append(sig) | ||
|
|
||
| for sig in sigs: | ||
| f.write(sig) |
Contributor
Author
There was a problem hiding this comment.
sig.encode("utf-8")
Contributor
Author
|
need to test this on py3, since i think there's some issues around str/bytes handling. |
|
Hi ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the updated script that @HongThatCong referenced in #97