add cryptix sysdeps - adjusted based on marv's guidelines #1451
Conversation
| @@ -0,0 +1,11 @@ | |||
| sysdep_supported_options = { | |||
| 'posix': true, | |||
| 'linux': true, | |||
There was a problem hiding this comment.
AFAICT the linux option seems to be incompatible with this PR - enabling this option requires providing linux kernel headers, while parts of this PR directly re-implement things they would provide.
| 'vfs.cpp', | ||
| ) | ||
|
|
||
| rtld_dso_sources += common_sources |
There was a problem hiding this comment.
Are you sure these should only go into the dso sources?
| size_t len = strlen(message); | ||
|
|
||
| long nwritten = 0; | ||
| do_log(MLIBC_SIG, sizeof(MLIBC_SIG)); |
There was a problem hiding this comment.
If you have a writev equivalent, it might be useful to use it here.
| return 0; | ||
| } | ||
|
|
||
| #pragma region |
There was a problem hiding this comment.
Where are these pragmas supported? AFAICT this is not listed by GCC or clang anywhere, but it doesn't give warnings because we use -Wno-unknown-pragmas.
There was a problem hiding this comment.
They are originally an MSVC extension but GCC >= 13 supports them and Clang since like 3.0 or something like that (+ they are only editor hints anyway to make the block of code between them foldable so they are ignored by the compilers).
| @@ -0,0 +1,3 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
This looks like it shouldn't be checked in - we already have a helper script.
| int sys_anon_allocate(size_t size, void **pointer); | ||
| } | ||
|
|
||
| LibraryGuard::LibraryGuard() { |
There was a problem hiding this comment.
Why is this here instead of just using the init_libc constructor?
| mov %rsp, %rdi | ||
| mov $main, %rsi | ||
| call __mlibc_entry | ||
| .section .note.GNU-stack,"",%progbitst |
There was a problem hiding this comment.
You might want to use GNU_STACK_NOTE from the mlibc-asm/helpers.h header.
No description provided.