V6.x - implement CryptixOS port #1450
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marv7000
suggested changes
Sep 11, 2025
There was a problem hiding this comment.
Sysdeps should follow the formatting of mlibc, do not do this!
| 'linux': true, | ||
| 'glibc': true, | ||
| 'bsd': true, | ||
| 'ansi': true, |
| provides_bits_syscall_h = false | ||
| if host_machine.system() == 'linux' | ||
|
|
||
| if host_machine.system() == 'cryptix' |
There was a problem hiding this comment.
You should add this at the end of the if, not at the start.
|
|
||
| size_t len = strlen(message) + 1; | ||
| char* messageEOL | ||
| = reinterpret_cast<char*>(alloca(len + sizeof(MLIBC_SIG))); |
There was a problem hiding this comment.
Why not just write multiple times? This alloca is unnecessary.
There was a problem hiding this comment.
Do not include Linux headers, their license is also not compatible!
|
Also, please redo the commits and try to follow the commit message style. |
|
Thanks for review, i'll make the adjustments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.