Print: save one request

[FilipChalupa]

No description provided.

[VojtaStanek]

Will it help? I think that browser wouldn't request print stylesheet unless it's needed. When it's in one file it does add some additional bytes that are not needed.

…

On Sat, 1 Jul 2017 9:14 pm Filip Chalupa, ***@***.***> wrote: ------------------------------ You can view, comment on, or merge this pull request online at: #22 Commit Summary - Print: save one request File Changes - *M* mango.yaml <https://github.com/manGoweb/mango-cli-example/pull/22/files#diff-0> (1) - *R* src/styles/_print.sass <https://github.com/manGoweb/mango-cli-example/pull/22/files#diff-1> (0) - *M* src/styles/index.sass <https://github.com/manGoweb/mango-cli-example/pull/22/files#diff-2> (3) - *M* src/templates/layouts/default.jade <https://github.com/manGoweb/mango-cli-example/pull/22/files#diff-3> (3) Patch Links: - https://github.com/manGoweb/mango-cli-example/pull/22.patch - https://github.com/manGoweb/mango-cli-example/pull/22.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#22>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEFagupiJLoPdqQwvHNm1_PLmw-odHkzks5sJpqZgaJpZM4OLZPT> .

[FilipChalupa]

Of course it will help. Check any project based on mango-cli-example in Google Chrome. Few bytes in index.css is cheaper than requesting another file.

I tried https://moje.rekola.cz and was no way near to printing it.

[FilipChalupa]

I fact the <link rel="stylesheet" href="/assets/styles/1499088762-print.css" media="print"> has more bytes which cannot be cached than @media print{img,picture{display:none;max-width:100%}} in cacheable index.css.

[enzy]

I would delay the load of a print style instead.

@media print{img,picture{display:none;max-width:100%}}

This is only a default style for print which needs to be extended based on a project you're working on. So it will grow in size.

[FilipChalupa]

It "never" does grow in size. Usually in small projects everybody forgets about print style. So merging it with index seems good to me. It saves the one request without any significant consequences. For larger projects coders should implement tailored solution for their specific needs.

BTW delaying print style load means adding more bytes to index.js. That is almost as bad as adding print styles to index.css.

[FilipChalupa]

If I may I would suggest getting rid of the default print styles completely. I don't see any reason why images should be skipped while printing. I can accept hiding navigation or adding urls next to <a> tags.