Skip to content

Fix for issue #815 #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 26, 2021
Merged

Fix for issue #815 #881

merged 7 commits into from
Jan 26, 2021

Conversation

enricodetoma
Copy link
Contributor

I produced a fix for the import errors/deprecations in issue #815.
With a recent version of Pandas, importing Panel results in an error, not just a future warning.
Please have a look at it.

@c-w-m c-w-m mentioned this pull request Jan 18, 2021
@bmoscon
Copy link
Collaborator

bmoscon commented Jan 22, 2021

@enricodetoma seems reasonable. Can you put in a pytest skip for the tests that use panels? You should be able to skip the tests based on the version of pandas

@bmoscon
Copy link
Collaborator

bmoscon commented Jan 23, 2021

@enricodetoma looks like just that import is missing then I can merge this

@enricodetoma
Copy link
Contributor Author

Sorry I forgot to check the Travis build for any residual errors after my commits...

@bmoscon
Copy link
Collaborator

bmoscon commented Jan 24, 2021

@jamesblackburn @TomTaylorLondon @shashank88 - this looks good to merge on my end - shouldn't break anything but allows users to use newer versions of pandas (the caveat being no more panel support when running a later version of pandas). Let me know what you think

@bmoscon bmoscon merged commit c7f001c into man-group:master Jan 26, 2021
dunckerr added a commit that referenced this pull request Oct 28, 2021
…n when querying symbols (#856)

* fix(list_symbols): Use IXSCAN queries for the versions collection when querying symbols

This is mainly a reversion on #520, but we add another index to avoid a FETCH stage which gives a massive speedup.

* feat(change_log): Adding the latest improvement to the changelog

* Update changes file for release

* Update setup.py

* Update CHANGES.md

* Fix flake8 errors (#875)

* docs: fix simple typo, verififes -> verifies (#877)

There is a small typo in arctic/store/_version_store_utils.py.

Should read `verifies` rather than `verififes`.

* Fix for issue #815 (#881)

* Handle uninitialized cache object

* Fixes #874: Pickle protocol 5 not supported in 3.7 and below

* Fixes #872: Do not spam if not permissioned on cache db

* Pin Pandas to check ck build

* Skip flaky test

* pin numpy as well for 3.7

* Update chunkstore.py

* Speedup FrametoArray serializer for ChunkStore by removing intermediate DataFrame construction. (#909)

* Fix column subsetting bug. (#910)

* circle.ci build config.yml (#917)

circle.ci build running. all tests passed
Co-authored-by: Kerr, Duncan (London) <Duncan.Kerr@man.com>

* master branch simple build (#918)

* do not release master branch build

* fix master build

Co-authored-by: Kerr, Duncan (London) <Duncan.Kerr@man.com>

* fixed build badge for master branch (#919)

Co-authored-by: Kerr, Duncan (London) <Duncan.Kerr@man.com>

* update CHANGES.md for v1.80.0 (#920)

Co-authored-by: Kerr, Duncan (London) <Duncan.Kerr@man.com>

* fix(list_symbols): Use IXSCAN queries for the versions collection when querying symbols

This is mainly a reversion on #520, but we add another index to avoid a FETCH stage which gives a massive speedup.

* feat(change_log): Adding the latest improvement to the changelog

* rebased Rob's changes to master 1.80.0

* fixed circleci typos

Co-authored-by: Bryant Moscon <bmoscon@gmail.com>
Co-authored-by: Tim Gates <tim.gates@iress.com>
Co-authored-by: enricodetoma <enrico.detoma@gmail.com>
Co-authored-by: Shashank Khare <shashank88@gmail.com>
Co-authored-by: Tom Taylor <TomTaylorLondon@users.noreply.github.com>
Co-authored-by: Dela B <37855280+BaiBaiHi@users.noreply.github.com>
Co-authored-by: duncan <duncan.kerr@live.com>
Co-authored-by: Kerr, Duncan (London) <Duncan.Kerr@man.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants