Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware - Support Request ID #123

Merged
merged 2 commits into from
May 9, 2020
Merged

Middleware - Support Request ID #123

merged 2 commits into from
May 9, 2020

Conversation

yashmurty
Copy link
Member

Changes:

  • Add middleware which does the following:
    • Check headers for x-request-id which can be set via client.
    • If empty, generate it (uuid) and add it to response headers.
    • Add this requestId to all logs.

@yashmurty yashmurty self-assigned this May 9, 2020
@DaisukeHirata DaisukeHirata merged commit 1084506 into master May 9, 2020
@yashmurty yashmurty deleted the yash/delete-org branch May 10, 2020 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaisukeHirata DaisukeHirata Awaiting requested review from DaisukeHirata

@shogo-mitomo shogo-mitomo Awaiting requested review from shogo-mitomo

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashmurty @DaisukeHirata @shogo-mitomo