Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix request body randomID to Array #112

Merged
merged 1 commit into from
May 6, 2020
Merged

🐛 Fix request body randomID to Array #112

merged 1 commit into from
May 6, 2020

Conversation

shogo-mitomo
Copy link
Member

No description provided.

@shogo-mitomo shogo-mitomo self-assigned this May 6, 2020
@shogo-mitomo shogo-mitomo added the bug Something isn't working label May 6, 2020
yashmurty
yashmurty approved these changes May 6, 2020
View reviewed changes
Copy link
Member

@yashmurty yashmurty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍
BTW, was there a discussion to move the payload to query params instead of request body?
I'm not sure what was the final conclusion. 🙏

src/users/users.repository.ts

if (!randomID) {
if (randomIDs.length === 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, it's also possible to do this way, of course both ways will give same result! 🙏

if(!randomIDs.length)

@shogo-mitomo shogo-mitomo merged commit ead939e into master May 6, 2020
@shogo-mitomo shogo-mitomo deleted the mitomo/random_ids branch May 6, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashmurty yashmurty yashmurty approved these changes

@DaisukeHirata DaisukeHirata Awaiting requested review from DaisukeHirata

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shogo-mitomo @yashmurty