wip: experimental support for version ranges in unsat errors #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aochagavia
force-pushed
the
version-ranges
branch
from
0a56c5e
to
a4559b7
Compare
wolfv
reviewed
Feb 8, 2024
| --- | ||
| The following packages are incompatible | ||
| ├─ a >=2, <20 can be installed with any of the following options: | ||
| │ └─ a 19 | >=16, <=17 | >=9, <=14 | >=2, <=7 |
There was a problem hiding this comment.
I was told that pubgrub has a implementation of a simplify algorithm for ranges like this (it would go and merge all the ranges that overlap so that the result would be the same range but expressed with fewer terms). I think in this case, it would be nice if it was simplified to >=2,<20 - although that is in fact what the "MatchSpec" above says ... so this thought might be futile anyways.
|
Closing this PR for now. We don't see an avenue forward for this as of yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I won't have time to finish up this PR properly, but I'm leaving it here because at least part of it might be interesting. The second commit could probably be cherry-picked and merged without too much additional work.
Experimental support for version ranges
@wolfv was enthusiastic about the idea, but we didn't really reach a consensus about how the feature would exactly work. The first commit contains a working implementation that you could tweak further. Check out the insta snapshots of the commit to see how it affects error messages.
Proper unicode characters in error messages
This means we stop using
|--and start using├─, and similar. There is some complexity associated to this change, because now we need to do some tracking to know which character we need (├─,└─or│). The implementation is in the second commit, but there are a few TODOs to clean up the code. Check out the insta snapshots of the commit to see how it affects error messages.